Align rename modals #62874
Merged
Align rename modals #62874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -24 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Nice work. The only one I don't agree with is the notice change, this one:
I can see sense in using the basic "Name" label for the input field, but I'd keep the help text below, and keep it as plain body text. The consequences are important to understand, but it doesn't need further elevation since you're already in a modal context. This is also mostly about that particular notice style being generally out of place in the block editor, it doesn't share any DNA with the snackbar, for instance. |
t-hamano
reviewed
Jun 27, 2024
|
Good feedback, I'll change the notice 👍 How do y'all feel about these questions?
|
|
Flaky tests detected in 7dedd28. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9698824225
|
No strong opinion.
Save read well to me. It's active language just like Rename, but benefits from the reduced duplication, while still being the action taken. |
I think accessibility feedback is needed on this. I remember that @afercia submitted some issues on this point to improve the consistency/accessibility of modals/dialogs. He might have some advice. |
|
Generally, visible labels are always better especially with complex forms with several input fields. Re: the buttons text, I provided some previous feedback but that was specifically about the |
|
I lean towards avoiding duplication too. But I am also slightly bothered by the inconsistency here: 
|
These inconsistencies will need to be fixed in the future. Considering avoiding the "OK" label and avoiding duplicate labels, my options for this PR are "Save", "Update", and "Apply". Of these, I prefer "Save", which means we'll ship this PR as is. |
Eheh yes that's a good case. I'd love to see some established guidelines added to the documentation of these components. Maybe it is worth creating a follow-up issue?. For reference, regarding the |
|
I'm going to flip-flop on this and lean towards repetition 🙊 for two main reasons:
I could be swayed back again, but I'm curious... if not "Duplicate", what would the primary button label be in the In any case, it's a broader topic, so I'm happy to ship this PR as is, and discuss the labels further in a separate issue/pr. |
t-hamano
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
In any case, it's a broader topic, so I'm happy to ship this PR as is, and discuss the labels further in a separate issue/pr.
I agree with this. This PR only includes one button text change, and by unifying everything to "Save", we have improved consistency.
I think the other issues can be addressed by following up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62788.
The vast majority of rename modals appear in the following format:
This PR brings a couple of outliers into alignment with this convention.
Navigation menus
Note the visible label.
Renaming blocks
Renaming custom views
Testing Instructions
Additional alignment considerations