Add arrow-parens rule to eslint config #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require that there are parens around the arguments of an arrow function.
aduth
approved these changes
Apr 19, 2018
|
mods are asleep, add parens! |
|
Nooooo 😱 I can no longer do my magic: param => ( { param } )😃 ( param ) => {
return { param };
}This is something we try to encourage anyways. |
|
@aduth 😆 |
4 tasks
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
Require that there are parens around the arguments of an arrow function.
|
First @pento sneaks a fundamental change to our ASCII art and now this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #611.
Require that there are parens around the arguments of an arrow function. This option got the most 👍 reactions in #611 (comment).
(I'm not that phased by this to be honest—it's just that I was in the neighbourhood while fixing #6263.)