Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter: Add close button #61421

Merged
merged 4 commits into from
May 8, 2024
Merged

Inserter: Add close button #61421

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18640d2
Inserter: Add close button
scruffian May 7, 2024
fbdf3e6
make button smaller
scruffian May 7, 2024
098b270
remove dialogRefs
scruffian May 8, 2024
7ea9ac2
update classnames
scruffian May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make button smaller
  • Loading branch information
@scruffian
scruffian committed May 8, 2024
commit fbdf3e67937088fd81b87addafd951c3bfd9bee6
1 change: 1 addition & 0 deletions packages/block-editor/src/components/inserter/tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function InserterTabs( { onSelect, children, onClose }, ref ) {
icon={ closeSmall }
label={ __( 'Close block inserter' ) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the label always be block inserter? Should we have a generic label for the inserter or update per selected tab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to update it, in a different PR :)

onClick={ () => onClose() }
size="small"
/>

<Tabs.TabList className="block-editor-inserter__tablist">
Expand Down