Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Storybook validator to static checks workflow #59189

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Adding Storybook validator to static checks workflow #59189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98ef30f
Adding Storybook validator to static checks workflow
Feb 20, 2024
8b00c6b
Fixing failing Storybook warnings
Feb 21, 2024
b733d5b
Merge branch 'trunk' into add-storybook-validator
Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/static-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
- name: Type checking
run: npm run build:package-types

- name: Validate Storybook
run: npm run storybook:validate

- name: Check local changes
run: npm run other:check-local-changes

Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,8 @@
"start": "npm run dev",
"prestorybook:build": "npm run build:packages",
"storybook:build": "storybook build -c ./storybook -o ./storybook/build",
"prestorybook:validate": "npm run build:packages",
"storybook:validate": "storybook dev -c ./storybook --ci --smoke-test",
"prestorybook:dev": "npm run build:packages",
"storybook:dev": "concurrently \"npm run dev:packages\" \"storybook dev -c ./storybook -p 50240\"",
"storybook:e2e:dev": "concurrently \"npm run dev:packages\" \"storybook dev -c test/storybook-playwright/storybook -p 50241\"",
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/global-styles/screen-revisions/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@

.edit-site-global-styles-screen-revisions__meta {
display: flex;
justify-content: start;
justify-content: flex-start;
width: 100%;
align-items: flex-start;
text-align: left;
Expand Down
2 changes: 1 addition & 1 deletion storybook/stories/playground/box/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
/**
* Internal dependencies
*/
import editorStyles from '../editor-styles';
import { editorStyles } from '../editor-styles';
import './style.css';

export default function EditorBox() {
Expand Down
2 changes: 1 addition & 1 deletion storybook/stories/playground/with-undo-redo/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { undo as undoIcon, redo as redoIcon } from '@wordpress/icons';
/**
* Internal dependencies
*/
import editorStyles from '../editor-styles';
import { editorStyles } from '../editor-styles';
import './style.css';

export default function EditorWithUndoRedo() {
Expand Down
Loading