Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTORS.md and CONTRIBUTING.md with calls for translations #5779

Merged
merged 3 commits into from
Mar 27, 2018

Conversation

robertsky
Copy link
Contributor

Description

Update CONTRIBUTORS.md and CONTRIBUTING.md with calls for translations

How Has This Been Tested?

Edited and viewed the markdown files on github.

Screenshots (jpeg or gifs if applicable):

Types of changes

Update CONTRIBUTING.md and CONTRIBUTORS.md.

Checklist:

  • No code changed.

Adding in a section to let (potential) contributors know that they can contribute translations to the project.
Add link to translation contributors page
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this section. Left one minor note about choice of terminology. Let me know how you'd like to proceed.

CONTRIBUTING.md Outdated
@@ -69,3 +69,13 @@ To add a new documentation page, you'll have to create a Markdown file in the [d
## Reporting Security Issues

Please see [SECURITY.md](./SECURITY.md).

## Internationalizing Gutenberg Plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As defined, I might think "Localizing" would be the preferred term here for contributors looking to submit strings.

https://www.w3.org/International/questions/qa-i18n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie. I have updated the heading. :)

Edited as per @aduth's suggestion.
@robertsky
Copy link
Contributor Author

@aduth I have updated the changes as you have suggested. :)

@aduth
Copy link
Member

aduth commented Mar 27, 2018

Thanks!

@aduth aduth merged commit af55057 into WordPress:master Mar 27, 2018
@robertsky robertsky deleted the patch-1 branch April 22, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants