-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: Add an e2e test to check image upload working in site editor #57086
Conversation
@kevin940726 even though this could technically go in with the |
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
Flaky tests detected in 67a59ad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7215822122
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice follow-up! @kevin940726 might have other feedback, but this looks good to me. Uses the same approach as the existing image tests, but applies it to the site editor. Co-locating the test for the time being sounds good to me, too 👍
✅ Tests pass with this PR applied
✅ Checking out 2fb3c57bcad
and applying this test update via git restore --source=add/site-editor-image-upload-e2e test/e2e/specs/editor/blocks/image.spec.js
results in this test failing as expected
LGTM! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. Thanks!
What?
Adds an e2e test to check that image uploading is working in site editor.
Why?
To prevent regressions of #57040
How?
Adds test to existing image block spec to avoid having to share the image utils across to the site editor specs folder just for one test.
Testing Instructions
npm run test:e2e:playwright specs/editor/blocks/image.spec.js
and check that all tests pass2fb3c57bcad
which was before the image upload bug was fixed to check that it failed