Use wordpress/es6 ESLint config
#5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
reviewed
Mar 18, 2018
eslint/config.js
Outdated
| @@ -2,6 +2,7 @@ module.exports = { | |||
| parser: 'babel-eslint', | |||
| extends: [ | |||
| 'wordpress', | |||
| 'wordpress/es6', | |||
There was a problem hiding this comment.
As discussed previously we might want to proceed with es-next to avoid confusion with all the recent versions of the JS language.
gziolo
reviewed
Mar 18, 2018
| @@ -39,7 +40,6 @@ module.exports = { | |||
| 'comma-spacing': 'error', | |||
| 'comma-style': 'error', | |||
| 'computed-property-spacing': [ 'error', 'always' ], | |||
| 'constructor-super': 'error', | |||
There was a problem hiding this comment.
computed-property-spacing is also es6 specific. Is there a way to identify whart also belong to es6?
There was a problem hiding this comment.
The ESLint rule list has a ES6 category of rules: https://eslint.org/docs/rules/#ecmascript-6
There was a problem hiding this comment.
Ah okey, that explains everything 😃
|
It feels like all non-react specific rules should go to |
|
@gziolo Done, this is ready for review and merge 👍 |
gziolo
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates ESLint ES6 rules out of Gutenberg and into the
eslint-plugin-wordpresspackage and thewordpress/es6configuration.This PR has a companion PR here WordPress-Coding-Standards/eslint-plugin-wordpress#137
How Has This Been Tested?
Proof of concept at the moment, testing to follow
Screenshots (jpeg or gifs if applicable):
Types of changes
Non-breaking change to the ESLint configuration
Checklist: