-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Fix Fixed warning in clean
script
#52447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
t-hamano
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
labels
Jul 9, 2023
dcalhoun
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching and addressing these errors.
I overlooked the usage of clean:jest
, I agree it makes sense to remove it.
The addition of true
to clean-watchman
mirrors the same script within the react-native-editor
package, so that makes sense to me as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the following two problems with scripts in the
react-native-editor
andreact-native-aztec
packages:react-native-editor
package, there are scripts that contain aclean:jest
script that does not exist.clean-watchman
fails in thereact-native-aztec
package if watchman is not installedFor example, if you run the following script, trunk will log errors.
npm run native start:reset
npm run native clean
How?
In the
react-native-editor
package, I have removedclean:jest
from the scripts. The script itself was removed in #51869.In the
react-native-aztec
package, I addedtrue
at the end to prevent an error if watchman is not installed.Testing Instructions
Confirm that the following two codes do not log errors:
npm run native start:reset
npm run native clean
This change should not affect the application, but I am not familiar with it, so if there is a problem I would be glad to hear about it.