Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drops PHP 5.6 CI jobs that run on WordPress trunk #52345

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Drops PHP 5.6 CI jobs that run on WordPress trunk #52345

merged 2 commits into from
Jul 5, 2023

Conversation

hellofromtonya
Copy link
Contributor

@hellofromtonya hellofromtonya commented Jul 5, 2023 •
edited
Loading

Part of #52344

What?

Drops the PHP 5.6 CI jobs that run on WordPress trunk.

Why?

WordPress Core dropped PHP 5.6 support on its trunk, raising its minimum version to 7.0. This caused the Gutenberg CI to fail on each of the PHP 5.6 jobs.

How?

Testing Instructions

All PHPCS and PHPUnit tests should now pass.

@hellofromtonya hellofromtonya added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jul 5, 2023
@aaronjorbin
Copy link
Member

Since it's possible to install the plugin on versions of WP besides Trunk, I think the plugin header should also have Requires PHP: 7.0 added if the plugin will no longer be testing PHP 5.6.

@hellofromtonya
Copy link
Contributor Author

Since it's possible to install the plugin on versions of WP besides Trunk, I think the plugin header should also have Requires PHP: 7.0 added if the plugin will no longer be testing PHP 5.6.

I agree @aaronjorbin.

But I'm thinking that change needs to happen in a separate PR after there's consensus on when to make the change. It's possible folks might want to wait until WordPress 6.3 ships (i.e. on Aug 8th).

So this PR focuses only on the CI jobs that are currently failing in the repo.

What do you think @aaronjorbin? Is it okay to separate the tasks into separate PRs?

@hellofromtonya
Copy link
Contributor Author

hellofromtonya commented Jul 5, 2023 •
edited
Loading

Also noting, the CI does test PHP 5.6 on a previous WordPress version. See this CI job https://github.com/WordPress/gutenberg/actions/runs/5468610960/jobs/9956487841?pr=52345.

@azaozz
Copy link
Contributor

azaozz commented Jul 5, 2023

that change needs to happen in a separate PR after there's consensus on when to make the change.

Yea, (afaik) Gutenberg supports the two latest WP releases, i.e. currently 6.1 and 6.2 while 6.3 is in the works. Bumping the minimum PHP version for the plugin would probably need to happen later.

@aaronjorbin
Copy link
Member

Also noting, the CI does test PHP 5.6 on a previous WordPress version.

Cool, then no objection to waiting from me

@hellofromtonya
Copy link
Contributor Author

Awesome. Thank you @aaronjorbin :)

@azaozz azaozz self-requested a review July 5, 2023 21:42
azaozz
azaozz approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@azaozz azaozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hellofromtonya
Copy link
Contributor Author

Awesome. Thank you @azaozz :)

@hellofromtonya hellofromtonya merged commit d9022ff into trunk Jul 5, 2023
49 checks passed
@hellofromtonya hellofromtonya deleted the try/drop-php56-in-ci branch July 5, 2023 21:45
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jul 5, 2023
@hellofromtonya hellofromtonya mentioned this pull request Jul 5, 2023
Closed
3 tasks
@hellofromtonya hellofromtonya changed the title Drops PHP 5.6 CI jobs Drops PHP 5.6 CI jobs that run on WordPress trunk Jul 5, 2023
@hellofromtonya hellofromtonya self-assigned this Jul 5, 2023
@Mamaduka Mamaduka added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 6, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Jul 6, 2023

This needs to be backported into the wp/6.3 branch to avoid CI failures there as well.

@hellofromtonya hellofromtonya mentioned this pull request Jul 6, 2023
Merged
tellthemachines pushed a commit that referenced this pull request Jul 7, 2023
@hellofromtonya @tellthemachines
Drop PHP 5.6 CI jobs (#52345)
5af8f46 
* Remove PHP 5.6 PHPUnit CI job
* Raise version in phpcs / WPCS
@tellthemachines
Copy link
Contributor

I just cherry-picked this PR to the update/first-pre-beta-4 branch to get it included in the next release: 5af8f46

@tellthemachines tellthemachines removed the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 7, 2023
tellthemachines added a commit that referenced this pull request Jul 7, 2023
@tellthemachines @SaxonF
@noisysocks @glendaviesnz @jameskoster @getdave @Mamaduka @draganescu @hellofromtonya @youknowriad @ellatrix @ramonjd @kevin940726 @richtabor @aaronrobertshaw @scruffian @stokesman @cbravobernal @ntsekouras @t-hamano @TimothyBJacobs @mcsf
Update/first pre beta 4 (#52400)
20ea9f1 
* add hint to show template part move (#52395)

* Page Content Focus: Ignore page content within a Query Loop block (#52351)

* Block Editor: Pass context and className props to editor.BlockEdit filter

* Page Content Focus: Ignore content blocks that are within a Query Loop

* Patterns: stop endless snackbars appearing (#52012)

* Patterns: Distinguish between theme patterns and template parts in category list (#52382)

* Allow opt out of auto-creation of Navigation fallback (#52319)

* Update welcome guide copy (#52282)

* Patterns: Update pattern copy (#52340)

* Post Title: The changes should be reflected when previewing a post (#52369)

* Update fixed block toolbar (#52123)

* update the icons for expanding and collapsing the fixed block toolbar

* hide the tools selector item in document tools for fixed toolbar preference

* reveal undo, redo and list view buttons

* tweaks for show icon labels and hide zoom out for top toolbar option

* improve the responsiveness of the fixed block toolbar

* remove the overflow rule - bad experiment

* update top toolbar test with the new label for buttons

* update the toolbar tests to account for moving the collapse button

* Drop PHP 5.6 CI jobs (#52345)

* Remove PHP 5.6 PHPUnit CI job
* Raise version in phpcs / WPCS

* Patterns: Add handling of sync status to the wp-admin patterns list page (#52346)

* Exit template focus when opening the W menu (#52235)

* wrap buttons (#52249)

* Update the behavior of the cached undo/redo stack (#51644)

Co-authored-by: Ella van Durpe <[email protected]>

* Adjust top position (#52248)

* Patterns: add a hint about the rename of reusable blocks to menu and inserter  (#51771)

Co-authored-by: Saxon Fletcher <[email protected]>

* Site Editor: update headings hierarchy in the 'Manage all' screens (#52271)

* This commit:
- updates heading levels on the template and template part pages
- passes a `level` prop to Header from Page

* update h2 size

* Rolling back custom sizes

* Rolling back unnecessary classNames
There was a rogue space in trunk. Let's let it live

* Check randomizer experiment is enabled before rendering button (#52306)

* Hide parent selector when parent is 'disabled' or 'contentOnly' (#52264)

* Fix incorrect aria-describedby attributes for theme patterns (#52263)

* Patterns: rename sync_status and move to top level field on rest return instead of a meta field (#52146)

* Fix default block dimensions visibility (#52256)

* core/heading

* core/details

* core/list

* core/table

* core/video

* core/verse

* core/social-links

* core/site-title

* core/site-tagline

* core/site-logo

* core/post-time-to-read

* core/gallery

* core/code

* core/categories

* core/audio

* core/archives

* Patterns: Display all custom template part areas in sidebar nav (#52355)

* Revert phpcs back to PHP 5.6 (#52384)

Reverts phpcs PHP compatibility version back to 5.6.

* Check if experiment enabled fr this time (#52315)

* Navigation: Remove one preloaded endpoint (#52115)

* default to showing status (#52226)

* Command palette: rename (#52153)

* Revise use of “command menu” to “command palette”.

Dropping "global" where it was used as well.

* Find “command center” and replace with “command palette”

* Image block and behaviors: Fix some warnings (#52109)

* Fix first warning

* Fix second warning - dividing a NaN

* Turn off DFM for style book and style editing (#52117)

* Add confirmation step when deleting a Template (#52236)

* [Command Palette]: Remove suggestion for deleting templates/parts (#52168)

* Update stepper styling in Home template details panel (#51972)

* Update stepper styling

* Remove !important

* [Edit Post]: Add toggle fullscreen mode and list view commands (#52184)

* Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu (#52222)

* Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu

* Move lines

* !important (#52025)

* Navigation in Site View: Readd the edit button (#52111)

* Fix UnitControl crashing on regex control characters.

Units are now escaped using `escapeRegExp` before concatenating them into a regular expression.

Fixes #52211.
---------

Co-authored-by: Mitchell Austin <[email protected]>

* Patterns: rename wp_block sync_status postmeta to wp_pattern_sync_status (#52232)

---------

Co-authored-by: Kai Hao <[email protected]>

* Site Editor Frame: Ignore Spotlight in view mode (#52262)

* Guide: Place focus on the guide's container instead of its first tabbable (#52300)

* Guide: Place focus on the guide's container instead of its first tabbable

* Update CHANGELOG

* Post editor: Require confirmation before removing Footnotes (#52277)

* Post editor: Require confirmation before removing Footnotes

Context: #52176

* BlockRemovalWarningModal: Limit width to 40rem

* Explain that footnotes are preserved. Add warning to Site Editor

* Fix react-dropdown-menu version to avoid breaking change from one of … (#52356)

* Fix react-dropdown-menu version to avoid breaking change from one if its dependencies.

* Changelog update

* move changelog entry to the right place

* Update package-lock

---------

Co-authored-by: Saxon Fletcher <[email protected]>
Co-authored-by: Robert Anderson <[email protected]>
Co-authored-by: Glen Davies <[email protected]>
Co-authored-by: James Koster <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: Andrei Draganescu <[email protected]>
Co-authored-by: Tonya Mork <[email protected]>
Co-authored-by: Riad Benguella <[email protected]>
Co-authored-by: Ella van Durpe <[email protected]>
Co-authored-by: Ramon <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Rich Tabor <[email protected]>
Co-authored-by: Aaron Robertshaw <[email protected]>
Co-authored-by: Ben Dwyer <[email protected]>
Co-authored-by: Mitchell Austin <[email protected]>
Co-authored-by: Carlos Bravo <[email protected]>
Co-authored-by: Nik Tsekouras <[email protected]>
Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: Timothy Jacobs <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Miguel Fonseca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaozz azaozz azaozz approved these changes

@anton-vlasenko anton-vlasenko Awaiting requested review from anton-vlasenko

Assignees

@hellofromtonya hellofromtonya

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hellofromtonya @aaronjorbin @azaozz @Mamaduka @tellthemachines