Library - make pattern title clickable #51898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I'm not sure about the visuals here. I guess the text should be white and then go to standard link blue color on hover/focus? |
|
Size Change: +96 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Thanks! I think maybe the whole grid item should be clickable, and maybe there should be some kind of hover effect about it. But that can be a whole other story. @SaxonF WDYT?
| <Heading level={ 5 }>{ item.title }</Heading> | ||
| <Heading level={ 5 }> | ||
| <Button | ||
| href={ href } |
There was a problem hiding this comment.
I don't think we need the href, do we?
92 tasks
Potentially the title element could be moved within the Not against merging this PR as an interim fix though. |
getdave
commented
Jun 27, 2023
talldan
reviewed
Jun 27, 2023
e1a2e3e
to
6240e40
Compare
|
Flaky tests detected in 6240e40. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5389014633
|
richtabor
previously requested changes
Jun 27, 2023
Yup, thus #51898 (comment). Thanks for the actionable feedback 👍 TBH I should have spotted this. |
|
@richtabor I updated the styling in 260ff9f. I took the liberty of including a subtle effect on |
Perhaps |
|
@richtabor Colors updated. Now seeking your ✅ |
|
The title should only act as a link for editable entries. Currently it is applied to everything, meaning I can open a theme pattern in the editor which leads to a very broken experience. |
Excellent catch. I feel like I'm diving in here without sufficient context around how Library works. Glad I've exercised caution here to ensure these types of errors don't creep in. |
Yea, theme patterns can't be edited (yet). Eventually they'll be treated similar to template parts, where you can edit/copy/customize them. |
dffd756
to
c9edace
Compare
scruffian
approved these changes
Jul 10, 2023
tellthemachines
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Use button inside title * Remove href * Preserve roving tab index * Fix link colors to match trunk $gray-600 * Remove redundant var * Amend colors as per review * remove old files again --------- Co-authored-by: scruffian <[email protected]>
|
I just cherry-picked this PR to the update/beta-4-second-round branch to get it included in the next release: 967ce9a |
tellthemachines
added a commit
that referenced
this pull request
Jul 11, 2023
* Post and Comment Template blocks: Change render_block_context priority to 1 (#52364) * Footnotes: fix lingering format boundary attr (#52439) * Footnotes: Fix incorrect anchor position in Firefox (#52425) * Scope CSS rules for the wp admin reset to js support only. (#52376) * Fix: Patterns & template parts: remove "apply globally" option from block settings (#52160) * Advanced styles panel: add an early return * Update index.js * Minor styling changes * Use array of features --------- Co-authored-by: George Mamadashvili <[email protected]> * make the body of the editor minimmum viewport height so that smaller contents maintain clickability (#52406) * Patterns: Add renaming, duplication, and deletion options (#52270) * Patterns: Update manage pattern links to go to site editor if available (#52403) * [Patterns] Separate sync status into a filter control (#52303) Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Glen Davies <[email protected]> * Patterns: Add missing decoding entities processing in Patterns and Template/Parts pages (#52449) * Fix document title icon appearance (#52424) * Quote block: Add transform to paragraph (#51809) * Add ungroup transform as transform to p * Lint * Update test and snapshot. --------- Co-authored-by: Juan Aldasoro <[email protected]> * remove sidebar group descriptions (#52453) * Patterns: alternative grid layout to improve keyboard accessibility (#52357) * add sync tooltip (#52458) * Patterns: Update section heading levels (#52273) * Ensure that the unsaved title is not persisted when reopening the modal (#52473) * Iframe: avoid asset parsing & fix script localisation (#52405) * Iframe: avoid asset parsing & fix script localisation * Add e2e test for script localisation * Update descriptions (#52468) * Footnotes: show in inserter and placehold (#52445) * Footnotes: show in inserter and placehold * Fix placeholder block membrane; fix copy; add icon, label --------- Co-authored-by: Miguel Fonseca <[email protected]> * Fix: Focus loss on navigation link label editing on Firefox. (#52428) * Update tooltip (#52465) * Refactor, document, and fix image block deprecations (#52081) * Refactor, document, and fix image block deprecations * Fix v5 attributes & supports * Fix v1 & v2 deprecation tests * Rename deprecated test descriptions * Respect custom aspect ratio (#52286) * add image width and height via css inline style, update width and height attrs to be string * keep width and height as attributes too, keep the attributes as numbers * updates image fixtures * RichText/Footnotes: make getRichTextValues work with InnerBlocks.Content (#52241) * RichText/Footnotes: make getRichTextValues work with InnerBlocks.Content --------- Co-authored-by: Miguel Fonseca <[email protected]> * Footnotes: save numbering through the entity provider (#52423) * Footnotes: save numbering through the entity provider * Add sup so no styling is needed at all * Migrate old format * Restore old styles, fix nested attribute queries * Fix anchor selection * Migrate markup in entity provider instead * Fix tests * Fix typo * Fix comment --------- Co-authored-by: Miguel Fonseca <[email protected]> * Revert "Post editor: Require confirmation before removing Footnotes (#52277)" (#52486) This reverts commit e6426ea. * List block: Fix selected type option (#52472) * Library - make pattern title clickable (#51898) * Use button inside title * Remove href * Preserve roving tab index * Fix link colors to match trunk $gray-600 * Remove redundant var * Amend colors as per review * remove old files again --------- Co-authored-by: scruffian <[email protected]> * remove status icon (#52457) * Rename block theme activation nonce variable. (#52398) --------- Co-authored-by: Bernie Reiter <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Andrea Fercia <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Juan Aldasoro <[email protected]> Co-authored-by: Miguel Fonseca <[email protected]> Co-authored-by: Jorge Costa <[email protected]> Co-authored-by: Alex Lende <[email protected]> Co-authored-by: Héctor <[email protected]> Co-authored-by: Petter Walbø Johnsgård <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Peter Wilson <[email protected]>
|
@getdave 👋 I see you marked this PR with the "Backport to Gutenberg RC" label. However, when trying to cherry-pick the merge commit to the Can you advise whether those changes should also be included in 16.2 (and if so, ideally help file a PR against the cc/ @fullofcaffeine |
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the title of a pattern in the Library clickable as well as the preview
Why?
The previews for Patterns in the library can take time to load/render. This means you have to wait to be able to click through to the pattern. It's inherently unstable UX.
By making the pattern title also clickable, we allow users to click through even if:
I also prefer the UX as I expected the pattern title to be clickable and it wasn't.
How?
Uses a Button in
linkvariant form, to click through to the same route as the preview click through.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast