Fix flaky tests in navigation.spec.js and other tests related to the Post Editor Template mode
#51790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
changed the title
navigation.spec.js
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
cbravobernal
added
[Block] Navigation
|
Ugh! There are still e2e tests that fail; they look unrelated, though... If they do not pass after re-running them, I'll probably merge this PR anyway. 🤷 EDIT: I link the failing tests for visibility |
|
|
DAreRodz
changed the title
navigation.spec.jsnavigation.spec.js and other tests related to the Post Editor Template mode
|
I fixed other tests that were failing (also locally) related to the Post Editor Template mode. I did so by waiting for the Editor canvas to be loaded before using the keyboard. |
noisysocks
force-pushed
the
fix/navigation-block-interactivity-e2e-tests
branch
from
9ee7e63
to
c0139fe
Compare
|
I rebased this so that #51826 is included. Hopefully there's a ✅ |
|
@DAreRodz the Puppeteer test finally passed, so even if that one is still flaky, I'm going to merge this to unblock Great work finding out the problem with these ones! 🎉 |
|
Oh, I missed the previous @noisysocks' comment. Thanks for the other fix, Robert 🙂 |
kevin940726
reviewed
Jun 28, 2023
| @@ -993,11 +993,9 @@ test.describe( 'Navigation block - Frontend interactivity', () => { | |||
| await expect( overlayMenuFirstElement ).toBeFocused(); | |||
|
|
|||
| // Test: overlay menu traps focus | |||
| await page.keyboard.press( 'Tab' ); | |||
| await page.keyboard.press( 'Tab' ); | |||
| await pageUtils.pressKeys( 'Tab', { times: 2, delay: 50 } ); | |||
There was a problem hiding this comment.
I love that it solves the issue and I have no problem merging this. I'm just wondering if there's an actual bug that makes us use delay, which is a last resort? It feels weird to me that Playwright has no problem tabbing through elements in the editor but is "too fast" in the frontend 🤔 . Maybe there's something obvious I'm missing though!
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…e Post Editor Template mode (WordPress#51790) * Add delay between consecutive keystrokes * Fix post editor template mode tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes flaky tests in the
navigation.spec.jsfile belonging to the 'Navigation block - Frontend interactivity' test group.Other tests were failing, this time related to the
Post Editor Template mode(see post-editor-template-mode.spec.js). I fixed them as well.Why?
The feature works fine, but tests are randomly failing because Playwright seems to fail with consecutive
Tabkeystrokes without a delay in between.How?
Replaced consecutive
page.keyboard.presscalls withpageUtils.pressKeys, passing a delay of 50 milliseconds.Testing Instructions
Automatic e2e tests should pass now.