[RNMobile] Update native BlockOutline component styles #51222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +53 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
This was referenced Jun 5, 2023
|
Hey @derekblank 👋 while doing a quick test of some E2E tests I saw an issue with the Columns block UI that we might need to find a way to solve somehow: Screen.Recording.2023-06-21.at.09.22.08.movIt looks like the dashed outline is hidden when the parent block is selected, I think we might need to show the dashed outline for this case so it doesn't look empty (at least when there aren't any blocks in the content) what do you think? We might need design feedback here. |
# Conflicts: # packages/react-native-editor/CHANGELOG.md
geriux
approved these changes
Jul 7, 2023
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the native BlockOutline component and supporting styles.
Related:
Why?
As part of ongoing editor UX improvements, the solid border around outer blocks and dashed border around inner blocks are being removed.
How?
Update styles and references to
BlockOutlinecomponent so that the main blue border around blocks is removed.Testing Instructions
Screenshots
NoOutlineTestBuild.1.mov