Introduce prepend_to_selector()
to avoid additional if checks and follow single responsibility principle
#50266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This implements the WP core PR WordPress/wordpress-develop#4380 in Gutenberg first, as requested on that PR, which makes sense given the current Gutenberg implementation differs slightly from current WP core's.
Why?
Having to check on every
append_to_selector()
call what the append position is inefficient and violates the single responsibility principle. The code that calls this method already knows whether it needs to append or prepend, so having a separateprepend_to_selector()
method with only that responsibility is more efficient.Related: #47833