useAsyncList: flush state updates when processing queue #48238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Package] Element
|
Size Change: +23 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Feb 20, 2023
| ...state, | ||
| ...list.slice( nextIndex, nextIndex + step ), | ||
| ] ); | ||
| } ); |
There was a problem hiding this comment.
While this PR restores the previous behavior (prior to the upgrade). I think it's still not perfect. Personally, I think we should be calling asyncQueue.add( {}, append( nextIndex + step ) ); outside the callback. kind of like I did here
There was a problem hiding this comment.
Personally, I think we should be calling
asyncQueue.addoutside the callback.
Pushed a commit that implements that 👍 Behavior-wise it's exactly the same, it just add all the work to the queue upfront, instead of adding each new task just in time right before the next iteration of the for of waitingList loop inside priority-queue.
|
Flaky tests detected in 47e7b5b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4222258567
|
|
Does this PR replace #48085 ? |
Yes it does 🙂 |
Here I ran an experiment where I removed |
Thank you so much for the heads up @youknowriad 🙇 ! As far as I checked, we don't use the hook |
youknowriad
approved these changes
Feb 20, 2023
youknowriad
added
the
Backport to WP 6.6 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 20, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.6 Beta/RC
fullofcaffeine
pushed a commit
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
useAsyncListin concurrent mode by usingReactDOM.flushSyncto synchronously run all the renders and effects triggered bysetState. Doing the work insiderequestIdleCallbackand consuming thetimeRemainingprovided by it.Fixes the issues discussed in #48085. In that discussion, I was wrong about
flushSyncnot being sync, and merely scheduling a microtask. It indeed is completely sync, doing all the rendering work and even effects synchronously. Very similar toact()in tests in this regard.I'm wondering how this will work in React Native.
flushSyncis areact-domAPI, not available in thereact-nativepackage.