Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation block: e2e code quality fixes #48071

Merged
merged 9 commits into from
Feb 15, 2023
Merged

Navigation block: e2e code quality fixes #48071

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1204cd0
code quality fixes
MaggieCabrera Feb 14, 2023
0177e64
add no pause rule
MaggieCabrera Feb 14, 2023
4b48833
Update .eslintrc.js
MaggieCabrera Feb 15, 2023
65dddac
Update test/e2e/specs/editor/blocks/navigation.spec.js
MaggieCabrera Feb 15, 2023
d304970
Update test/e2e/specs/editor/blocks/navigation.spec.js
MaggieCabrera Feb 15, 2023
b81b61a
Update test/e2e/specs/editor/blocks/navigation.spec.js
MaggieCabrera Feb 15, 2023
0b06258
Update test/e2e/specs/editor/blocks/navigation.spec.js
MaggieCabrera Feb 15, 2023
0226cde
remove type from docs
MaggieCabrera Feb 15, 2023
f54031b
add page as an argument
MaggieCabrera Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/e2e/specs/editor/blocks/navigation.spec.js 
Co-authored-by: Kai Hao <[email protected]>
  • Loading branch information
@MaggieCabrera @kevin940726
MaggieCabrera and kevin940726 committed Feb 15, 2023
commit d3049702cadbe7a1063c4644e5752c2cfd492afe
4 changes: 2 additions & 2 deletions test/e2e/specs/editor/blocks/navigation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ test.describe(
await page.locator( 'role=button[name="Close panel"i]' ).click();

// Check the block in the frontend.
await this.page.goto( '/' );
await page.goto( '/' );
await expect(
this.page.locator(
page.locator(
`role=navigation >> role=link[name="WordPress"i]`
)
).toBeVisible();
Expand Down