Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Performance: improve params in block_core_navigation_get_most_recently_published_navigation #47998

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Navigation: Performance: improve params in block_core_navigation_get_most_recently_published_navigation #47998

merged 1 commit into from
Feb 13, 2023

Conversation

spacedmonkey
Copy link
Member

What?

When quering for navigation post type, there is no need for post meta and term data. Pass these params.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@spacedmonkey spacedmonkey self-assigned this Feb 13, 2023
@github-actions
Copy link

Flaky tests detected in 53fd143.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4159002737
📝 Reported issues:

draganescu
draganescu approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good tweak, thanks @spacedmonkey

@spacedmonkey spacedmonkey merged commit ea74a30 into trunk Feb 13, 2023
@spacedmonkey spacedmonkey deleted the fix/query-args branch February 13, 2023 14:11
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 13, 2023
@spacedmonkey spacedmonkey added [Type] Performance Related to performance efforts [Block] Navigation Affects the Navigation Block labels Feb 13, 2023
@DaisyOlsen DaisyOlsen added the [Feature] Blocks Overall functionality of blocks label Feb 14, 2023
@DaisyOlsen DaisyOlsen changed the title Performance: improve params in block_core_navigation_get_most_recently_published_navigation Navigation: Performance: improve params in block_core_navigation_get_most_recently_published_navigation Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Package] Block library /packages/block-library label Feb 14, 2023
@spacedmonkey spacedmonkey added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 1, 2023
ntsekouras pushed a commit that referenced this pull request Mar 7, 2023
@spacedmonkey @ntsekouras
Set update_post_meta_cache and update_post_term_cache as false. (#47998)
0f5436c 
Co-authored-by: Jonathan Harris <[email protected]>
@ntsekouras
Copy link
Contributor

I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 0f5436c

@ntsekouras ntsekouras removed the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@getdave getdave Awaiting requested review from getdave

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Navigation Affects the Navigation Block [Feature] Blocks Overall functionality of blocks [Package] Block library /packages/block-library [Type] Performance Related to performance efforts
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spacedmonkey @ntsekouras @draganescu @DaisyOlsen