Remove the nux package #46110
Merged
Remove the nux package #46110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Size Change: -3.62 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Won't doing this break backwards compatibility for |
It is a breaking change, the idea is that it's low impact and that the developers have been notified about it for a long time now. (At least 26 months) |
|
I don't have a real opinion for how to best deal with this. Just wanted to share the usage data here in the ticket:
|
|
Thanks for the links @fabiankaegy that's very helpful. I tried to go through the results to assess how valid are these results. I found that most of the results (like 99%) of the So for the second search query, a number of plugins mention Other than that, there seem to be only two plugins that may be using the wp.nux global:
|
jorgefilipecosta
approved these changes
Dec 8, 2022
youknowriad
force-pushed
the
remove/nux
branch
from
06d0e79
to
642bba9
Compare
👍 makes sense. Might be worth preparing the Core patch now. |
youknowriad
force-pushed
the
remove/nux
branch
from
642bba9
to
5144808
Compare
|
I'll see if I can prepare the core patch |
|
Core patch available here WordPress/wordpress-develop#3775 |
|
Thanks @youknowriad 🙌 |
I have reached out to them :) Apologies for the delay here. I accidentally marked this as read and happened to stumble back on it. |
9 tasks
19 tasks
peterwilsoncc
added a commit
that referenced
this pull request
Jul 10, 2023
This reverts commit 9ea80f6.
peterwilsoncc
added a commit
that referenced
this pull request
Jul 10, 2023
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
peterwilsoncc
added a commit
that referenced
this pull request
Jul 10, 2023
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
peterwilsoncc
added a commit
that referenced
this pull request
Jul 17, 2023
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
peterwilsoncc
added a commit
that referenced
this pull request
Jul 17, 2023
* Revert "Remove the nux package (#46110)" This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php * Set peterwilsoncc as owner following revert. * Update rememo for nux to match other packages. * Update docs per precommit check. * Remove unused wp-nux CSS dependency. See * WordPress/wordpress-develop@8a6afdd * https://core.trac.wordpress.org/ticket/57827 * Use legacy fake timers for tests. * Update nux snapshot. The addition of the transforms of 0 pixels can be added safely as they have no effect. * Update starting version following e086b2b
peterwilsoncc
added a commit
that referenced
this pull request
Jul 17, 2023
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
peterwilsoncc
added a commit
that referenced
this pull request
Jul 18, 2023
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
peterwilsoncc
added a commit
that referenced
this pull request
Jul 19, 2023
* Revert "Remove the nux package (#46110)" This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php * Set peterwilsoncc as owner following revert. * Update docs per precommit check. * Remove unused wp-nux CSS dependency. See * WordPress/wordpress-develop@8a6afdd * https://core.trac.wordpress.org/ticket/57827 * Update rememo for nux to match other packages. * Use legacy fake timers for tests. * Update nux snapshot. The addition of the transforms of 0 pixels can be added safely as they have no effect. * Update starting version following e086b2b * Update starting version following 57ab3bd
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This package has been marked for removal for WordPress 6.2. There's no precedent on how to proceed with package removals. I've elected to remove it entirely to cleanup the repository properly. Let me know if you think there are any downsides to this. Also I think we have tools that rely on the presence of the folders so better to get rid of it to avoid performing builds... for this folder.
We'd need to follow-up on this on WordPress Core to actually remove the dependency and the script handle.