Fix: PHP 8.1 Deprecation - strncmp(): Passing null to parameter #44829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
reviewed
Oct 10, 2022
There was a problem hiding this comment.
I haven't had a chance to test this yet, but in principle it sounds like a safe change — the previous PR resolved the earlier issue by removing the '' empty string fallback. This PR doesn't make a change to the value of $value so sounds pretty safe.
I suppose another option might be to update the check to if ( ! is_string( $value ) ) {, but I don't have a strong preference either way. Thanks for putting this PR up!
andrewserong
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
This LGTM, just re-tested the issue resolved in #43925 by @matiasbenedetto, and confirmed that this PR doesn't re-introduce the regression 👍
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If the
$valueisnull, we don't need to do some string checks, because they throw PHP 8.1 deprecation messages:strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated.Fixes: #44792