Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PHP 8.1 Deprecation messages #44828

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix: PHP 8.1 Deprecation messages #44828

merged 1 commit into from
Oct 11, 2022

Conversation

Soean
Copy link
Member

@Soean Soean commented Oct 10, 2022

What?

Fixes two PHP 8.1 Deprecation messages.

  • Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
  • Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

The first three parameter of add_submenu_page need to be strings.

@Soean Soean self-assigned this Oct 11, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 11, 2022
@Soean Soean merged commit bac2c08 into trunk Oct 11, 2022
@Soean Soean deleted the php-dep-fix branch October 11, 2022 14:24
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants