Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: instruct people to keep using wp-scripts even when extending webpack #44348

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

luisherranz
Copy link
Member

What?

I've added a note in the wp-scripts docs to ensure people keep using the wp-scripts commands when they extend webpack.

Why?

Because wp-scripts initializes some values (like process.env.WP_SRC_DIRECTORY) that the webpack configuration expects, so it doesn't work when using webpack's CLI directly.

How?

I've added a note in the "Extending the webpack config" section.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to remind that it works best when combined with wp-scripts 👍🏻

@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Package] Scripts /packages/scripts labels Sep 22, 2022
@luisherranz
Copy link
Member Author

Thanks, Greg!

@luisherranz luisherranz merged commit f7ca79d into trunk Sep 22, 2022
@luisherranz luisherranz deleted the docs/use-wp-scripts-commands-when-extending branch September 22, 2022 08:39
@github-actions github-actions bot added this to the Gutenberg 14.3 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants