Use prefix theme_json_ in hooks related to theme.json
#44189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ramonjd,
scruffian,
aaronrobertshaw and
ajlende
oandregal
added
[Type] Code Quality
This was referenced Sep 15, 2022
|
@c4rl0sbr4v0 @ockham @michalczaplinski I'm waiting for this one to pass before merging. I'm not sure about the timing for 14.1 but I can backport it when merged. |
|
Cherry-picked to |
cbravobernal
added
the
Backport to Gutenberg RC
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 15, 2022
This consolidates the name of a filter introduced earlier in the 6.1 cycle, renaming it from `get_style_nodes` to `theme_json_get_style_nodes` as to be more coherent with the other hooks introduced in 6.1 as well. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#44189 #44189 Use prefix 'theme_json_' in hooks related to theme.json] Reference: [#3247 #3247 Add hooks to filter theme.json data]. Follow-up to [54118]. Props oandregal, scruffian, bernhard-reiter. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54183 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 15, 2022
This consolidates the name of a filter introduced earlier in the 6.1 cycle, renaming it from `get_style_nodes` to `theme_json_get_style_nodes` as to be more coherent with the other hooks introduced in 6.1 as well. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#44189 #44189 Use prefix 'theme_json_' in hooks related to theme.json] Reference: [WordPress/wordpress-develop#3247 #3247 Add hooks to filter theme.json data]. Follow-up to [54118]. Props oandregal, scruffian, bernhard-reiter. See #56467. Built from https://develop.svn.wordpress.org/trunk@54183 git-svn-id: http:https://core.svn.wordpress.org/trunk@53742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Sep 15, 2022
This consolidates the name of a filter introduced earlier in the 6.1 cycle, renaming it from `get_style_nodes` to `theme_json_get_style_nodes` as to be more coherent with the other hooks introduced in 6.1 as well. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#44189 #44189 Use prefix 'theme_json_' in hooks related to theme.json] Reference: [WordPress/wordpress-develop#3247 #3247 Add hooks to filter theme.json data]. Follow-up to [54118]. Props oandregal, scruffian, bernhard-reiter. See #56467. Built from https://develop.svn.wordpress.org/trunk@54183 git-svn-id: https://core.svn.wordpress.org/trunk@53742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
This consolidates the name of a filter introduced earlier in the 6.1 cycle, renaming it from `get_style_nodes` to `theme_json_get_style_nodes` as to be more coherent with the other hooks introduced in 6.1 as well. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#44189 #44189 Use prefix 'theme_json_' in hooks related to theme.json] Reference: [WordPress/wordpress-develop#3247 #3247 Add hooks to filter theme.json data]. Follow-up to [54118]. Props oandregal, scruffian, bernhard-reiter. See #56467. Built from https://develop.svn.wordpress.org/trunk@54183
ockham
added
the
Backport to WP 6.6 Beta/RC
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: ac50ea8 |
ockham
removed
the
Backport to WP 6.6 Beta/RC
aaronrobertshaw
removed
the
Backport to Gutenberg RC
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
This consolidates the name of a filter introduced earlier in the 6.1 cycle, renaming it from `get_style_nodes` to `theme_json_get_style_nodes` as to be more coherent with the other hooks introduced in 6.1 as well. This commit backports the original PR from Gutenberg repository: * [WordPress/gutenberg#44189 #44189 Use prefix 'theme_json_' in hooks related to theme.json] Reference: [WordPress#3247 WordPress#3247 Add hooks to filter theme.json data]. Follow-up to [54118]. Props oandregal, scruffian, bernhard-reiter. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54183 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames the filter
get_style_nodestotheme_json_get_style_nodes.Why?
We've introduced a number of filters for
theme.jsonin this cycle:theme_json_default,theme_json_blocks,theme_json_theme,theme_json_user. 44015 and 44159get_style_nodes41160With so many hooks in core, it helps discoverability and devexp that we use a coherent names for things that are related.
How?
Renames the calls to the filter.
Testing Instructions
See #41160