Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress (Highly Experimental)
This PR seeks to explore setting up a grid as the layout manager for the editor content. It absorbs the responsibility of handling
wide
andfull
widths. A theme should be able to overwrite the grid and every block would fall into place. This should greatly simplify calculations for presence of sidebar (collapsed or not). The biggest challenge is accommodating floats without changing the editor markup.This follows early explorations by @mor10.
Extra Alignment Options
Another thing this enables is registering extra alignment options (pulled content, side-by-side cards, etc) that a user can easily toggle with one click.
See this rough video for some of these explorations: https://cloudup.com/cxerBaTpMI9
Themes
A theme should be able to overwrite the grid template definition and, if using the same named areas, all content and alignment possibilities should follow through.
Concerns
The grid paradigm is fundamentally incompatible with floating and wrapping direct descendant nodes. That means if we want to support both, we need to add a container wrapper to the elements that want to interact in a float context.