Writing flow: fix Shift+Arrow partial selection for lists & quote #42885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +2.06 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
|
I've been testing selection with keyboard and this is what I've found:
Gravacao.de.ecra.a.partir.de.05-08-2022.12.46.39.webm
Gravacao.de.ecra.a.partir.de.05-08-2022.12.51.16.webmGravacao.de.ecra.a.partir.de.05-08-2022.12.47.31.webm@ellatrix For nested list, does it make sense that the selected nested item collapses into the item before when the selection is removed? This is, if I have: - one top-level
- two top-level
- one nested
- two nestedIf I select from "one" in "one nested" back to "top-level" in "two top-level" and then hit remove, the result would be: - one top-level
- two nested
- two nested |
This was referenced Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows Shift+Arrow(Up|Down) keyboard partial selection for a variety of situations.
Why?
It should be possible to selection multiple blocks with the keyboard from any block.
How?
Currently there's some conditions that prevent selection from happening. These condition where around before the introduction of partial selection, but they don't make sense anymore. Whenever the user tries to Shift+Arrow select form any editable element and selection reaches the edge, we should allow selection outside that box. The selection observer then selects the appropriate blocks in the store.
Testing Instructions
Create a v2 List and select across list items with the keyboard. Also try nested lists.
Create a Quote block with some content and try to multi select the previous or following block from inside the quote with the keyboard.
Screenshots or screencast