-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lodash: Remove most of it from @wordpress/element
package
#41903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
Related to performance efforts
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Element
/packages/element
labels
Jun 23, 2022
tyxla
requested review from
aristath,
gziolo,
swissspidy,
nerrad,
chad1008,
ntsekouras and
fabiankaegy
June 23, 2022 10:39
tyxla
commented
Jun 23, 2022
@@ -653,7 +646,9 @@ export function renderNativeComponent( | |||
// place of children. Ensure to omit so it is not assigned as attribute | |||
// as well. | |||
content = renderChildren( props.value, context, legacyContext ); | |||
props = omit( props, 'value' ); | |||
// eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this ESLint ignoring comment once #41897 is shipped.
Size Change: +3 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
chad1008
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Element
/packages/element
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes most of the Lodash from the
@wordpress/element
package. We're targeting the more common and easy to convert usages, leaving the rest for another time.This PR addresses a big part of #16938.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetch
package haslodash
as a dependency #39495How?
We're using the built-in
String.prototype.startsWith()
instead ofstartsWith()
,Object.keys().length
to work around theisEmpty()
usage, destructuring with rest props instead ofomit()
, andArray.isArray( x ) ? x : [ x ]
instead ofcastArray()
.Testing Instructions
Verify all tests pass:
npm run test-unit packages/element