Post Author block: Hide select author controle if there is no postId #40910
Conversation
There was a problem hiding this comment.
@mauriac thank you for working on this. Changes works as expected. I don't see any select dropdown to change author in the block settings when postId doesn't exist.
thanks to handle this. |
ZebulanStanphill
added
[Block] Post Author
| ) } | ||
| { !! postId && | ||
| ! isDescendentOfQueryLoop && | ||
| !! authors?.length && ( |
There was a problem hiding this comment.
Do both !! postId and ! isDescendentOfQueryLoop need to be checked?
There was a problem hiding this comment.
I have removed the ! isDescendentOfQueryLoop and run some tests and everything seems to be fine. But are we sure that _ isDescendentOfQueryLoop_ will be false each time when _ postId_ will be defined? is there a way to confirm that? Thanks.
There was a problem hiding this comment.
Does postId get passed via context to author blocks in query loops when the query loop is in a post? if it does then we need to keep ! isDescendentOfQueryLoop otherwise no.
If there is no postId the select, in post author block, that helps to change post author is hidden.
What?
fixes: #40909
Why?
How?
Testing Instructions
Screenshots or screencast