Table of Contents block: remove editor-only wrapper <div>.
#40899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Enhancement
|
Size Change: +13 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
Good First Review
I'm not sure how to do it? I tried it but no luck! Could you help me how to make |
|
@amustaque97 What I mean is that the links in the Table of Contents block shouldn't go anywhere when clicked. |
You mean convert to static list? OR Do I need to
|
|
@amustaque97 No, I mean that that clicking the links in the Table of Contents block should only ever select the block, and not activate the links (in contrast to the front-end behavior). |
amustaque97
approved these changes
May 8, 2022
There was a problem hiding this comment.
Tested the changes. It works as expected. Thank you for working on this @ZebulanStanphill 👏👏👏
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the extra
<div>in the Table of Contents block editor markup between the<nav>and<ol>.Why?
This makes the markup consistent between the editor and front-end, which will be helpful for future PRs. Specifically, I was working on a PR to add color controls to this block, and I didn't want to write editor-only styles to deal with the extra
<div>.How?
By switching to
useDisabledinstead of the<Disabled>component, we can disable the<ol>of the Table of Contents directly, instead of having to wrap it.Testing Instructions
trunk.