Cover: Update background type when using featured image #40873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
May 6, 2022
draganescu
approved these changes
May 6, 2022
|
@draganescu, I don’t think we need to keep them if the block doesn’t use those attributes. |
draganescu
added
the
Backport to WP 6.6 Beta/RC
|
I cherry-picked this PR for WordPress 6.0 RC2 with 9e782ed. |
gziolo
removed
the
Backport to WP 6.6 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #40871.
PR fixes the issue when the cover block displays video on the front end even after selecting the "Use featured image" option.
Why?
The featured image toggle action didn't update the
backgroundTypeattribute, and therender_callbackonly changes the block content for the image background type.I understand this action is meant to be "non-destructive," but the block generates incompatible markup for the render callback without this change.
Users can use the "undo" functionality to restore the original state of the block.
How?
Updates
toggleUseFeaturedImagecallback to rest required attributes.Testing Instructions