Use get_the_post_thumbnail function in the cover block.
#40853
Conversation
spacedmonkey
added
[Type] Performance
spacedmonkey
requested review from
draganescu,
adamziel,
getdave,
gziolo and
hellofromtonya
spacedmonkey
changed the title
get_the_post_thumbnail function is used for cover block. get_the_post_thumbnail function in the cover block.
There was a problem hiding this comment.
@spacedmonkey Great catch! This does not only come with improvements for consistency and performance, but also accessibility. 🎉
Please check the CI failures. Other than that I'm happy to approve it.
|
|
||
| $image = sprintf( | ||
| $image_template, | ||
| esc_attr( get_the_post_thumbnail_caption() ), |
There was a problem hiding this comment.
This was in fact incorrect and could result in accessibility problems, since it was using the caption as the alt attribute, when in fact WordPress images have their own dedicated field to define the alternative text.
So fixing that is another benefit of this PR.
There was a problem hiding this comment.
Great catch, I think it resulted like this as I didn't consider that featured images are their own kind of entity in WP, instead treated it as another simple image added to the cover block.
| ); | ||
|
|
||
| $image = get_the_post_thumbnail( null, 'post-thumbnail', $attr ); |
There was a problem hiding this comment.
This makes total sense, we shouldn't manually create img tags in WordPress core when dealing with attachments.
|
Excellent, thanks for working on this @spacedmonkey! |
| if ( in_the_loop() ) { | ||
| update_post_thumbnail_cache(); | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
This looks good to me.
The change adds several attributes to the image tag
loadingsrcsetsizeswidthheightclasschanges fromwp-block-cover__image-backgroundtowp-block-cover__image-background wp-post-image
I think all these are good things provided the width and height don't affect object fit.
No changes when the image is used as a background URL.
gziolo
added
the
Backport to WP 6.6 Beta/RC
|
I fixed a couple of PHP Coding-Standards issues, once test pass this can be merged 👍 |
|
I cherry-picked this PR for WordPress 6.0 RC2 with 93befd1. |
gziolo
removed
the
Backport to WP 6.6 Beta/RC
* Improve logic. * Improve logic. * Coding Standards: Using single-quotes if double-quotes are not required Co-authored-by: Ari Stathopoulos <[email protected]>
What?
Follow on from #39658.
Why?
Improved logic, to that if cover is not an image, then do not both to load feature image.
Ensure that
get_the_post_thumbnailfunction is called, so that filters are run correctly.Ensure that
update_post_thumbnail_cacheis called, so that feature image are loaded into memory.How?
Testing Instructions
Screenshots or screencast