Post Comments Block: Allow placeholders to reorder items in translations #40849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
|
Size Change: -461 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ockham
added
the
Backport to WP 6.6 Beta/RC
cbravobernal
requested review from
ockham,
SantosGuillamot,
luisherranz,
michalczaplinski,
DAreRodz,
peterwilsoncc and
a team
ockham
reviewed
May 5, 2022
Comment on lines
+115
to
+116
| /* translators: %s: Post title. */ | ||
| sprintf( __( 'One response to %s' ), postTitle ) |
There was a problem hiding this comment.
|
If possible, I'd vote for getting this into 6.0:
|
| </p> | ||
| </div> | ||
|
|
||
| <div className="reply"> | ||
| <a | ||
| className="comment-reply-link" | ||
| href="#top" | ||
| aria-label="Reply to A WordPress Commenter" | ||
| aria-label={ __( | ||
| 'Reply to A WordPress Commenter' |
There was a problem hiding this comment.
Could this use the following to avoid new strings?
/* translators: Comment reply button text. %s: Comment author name. */
sprintf(
__( 'Reply to %s' ),
__( 'A WordPress Commenter' )
);| </span> | ||
| { createInterpolateElement( | ||
| __( | ||
| '<b><a>A WordPress Commenter</a></b> <span>says:</span>' |
There was a problem hiding this comment.
Is it possible to use something like this to closer match the WP Core strings?
sprintf(
/* translators: %s: Comment author link. */
__( '%s <span>says:</span>' ),
sprintf( '<cite><a>%s</a></cite>', __( 'A WordPress Commenter' ) )
)I think the answer might be no because of how createInterpolateElement() is intended to work but I'd rather ask.
There was a problem hiding this comment.
If we don't add any class to the translation string, createInterpolateElement() works fine. 🎉
ockham
approved these changes
May 6, 2022
|
I cherry-picked this to wp/6.0 branch to be included in WordPress 6.0 RC2 later today 4013384 |
adamziel
removed
the
Backport to WP 6.6 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
With the Comments Placeholder task, we created some translatable fields. These previous ones had the phrase order hardcoded, so the translators could not select in what order the phrases are constructed.
Why?
Because we love the fact that WordPress is in almost all languages ❤️
How?
By using provided functions. I'm afraid that new strings will appear for the translations.
Before:
{ __( 'One response to' ) } “{ postTitle }”-> Translator can only change the first sentence, being mandatory to show the post title at the end.After:
sprintf( __( 'One response to %s' ), postTitle )-> Translator can move %s wherever they need to.Testing Instructions
1.) Translate the new strings and check that you can use the order you need.
Screenshots or screencast