Code Editor: Fix save shortcut #40848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
mcsf
approved these changes
May 5, 2022
|
Thanks for the review, @mcsf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes Code editor save shortcut when visual editing is disabled from the user profile.
P.S. I also couldn't resist and refactored components to use data hooks.
Why?
The component wasn't rendering
TextEditorGlobalKeyboardShortcutsif visual editing was disabled.How?
I moved the keyboard shortcuts component outside of the check.
Testing Instructions