Return immediately from Avatar block's render_callback if $comment is null
#40835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalczaplinski
changed the title
$comment is null
michalczaplinski
added
[Package] Block library
gziolo
approved these changes
May 5, 2022
cbravobernal
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the Avatar block's
render_callback, return''immediately if$commentisnull.Why?
If the comment is
null, accessing$comment->$comment_authorwill fail.In theory, the comment should never be
nullif$block->context['commentId']is set, but I was able to accidentally get my machine into a state where it did occur.Testing Instructions
I don't quite know how to reproduce it anymore. On my local machine, using twenty twentytwo, I got this error on the frontend:
However, this error went away after I've restarted my
wp-envenvironment.