Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Title: Make non-editable #40817

Merged
merged 9 commits into from
May 6, 2022
Merged

Comments Title: Make non-editable #40817

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d9dd74d
Comments Title: Make non-editable
ockham May 4, 2022
d1580ec
Avoid showing 'undefined' while loading
ockham May 4, 2022
93f155e
Update php to handle conditionals
cbravobernal May 4, 2022
873ef31
Rename comment title variable
cbravobernal May 4, 2022
02ab27a
Add initial deprecation
cbravobernal May 4, 2022
4ebf66e
Add supports deprecation
cbravobernal May 4, 2022
da45fac
Add integration test for deprecation
ockham May 4, 2022
b323447
Remove not needed check
cbravobernal May 5, 2022
ec89431
Number format only on sprintf
cbravobernal May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid showing 'undefined' while loading
  • Loading branch information
@ockham
ockham committed May 4, 2022
commit d1580ec184882e08aca52a9cf66b85d67b0b6fc6
2 changes: 1 addition & 1 deletion packages/block-library/src/comments-title/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default function Edit( {
const postTitle = isSiteEditor ? __( '"Post Title"' ) : `"${ rawTitle }"`;

let placeholder;
if ( showCommentsCount ) {
if ( showCommentsCount && commentsCount !== undefined ) {
if ( showPostTitle ) {
if ( commentsCount === 1 ) {
/* translators: %s: Post title. */
Expand Down