Add missing "type" to the search field on the editor #40782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
apeatling
approved these changes
May 3, 2022
|
I think it could be worth getting accessibility feedback on this. The change makes screenreaders announce this input as a search field, but it isn't a search field, it's an input for setting the placeholder test. |
|
There seems to be no A11Y concerns that I know about here. I do see stuff about how |
The way I was thinking about it here is that using |
|
@aristath In this case, |
|
Hmmm OK... I didn't know that, thank you! So yay or nay for adding it? If it's mostly for visuals, then it should not have a negative impact on screen readers, right? (Thank you for the timely response!) |
|
If there are no accessibility concerns, then adding the type makes the front and editor match, and makes it easier for theme developers to style all search input fields with the same styles. |
|
@aristath It really should not effect accessibility. I made a test in my own browser to check it and |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a missing
type="search"to the search field in the editor.Why?
type="search"gets added, while on the editor it does not exist[type="search"]. This change allows using the same CSS both on the front and the editor, thus eliminating the need for a separate editor stylesheet (for example Tailwind uses that selector)How?
Adds
type="search"to the input field inedit.jsTesting Instructions
Add a search block and confirm that it has the type defined.