Borders: Remove unused BorderStyleControl component #40635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Feature] UI Components
|
Size Change: -350 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Looks good to me, I couldn't see any other uses and everything built and ran ok, but I would be interested to hear from someone that has had experience with removing experimental APIs before signing off on it, just to confirm no deprecation period is needed. |
|
@glendaviesnz I've asked around with those more in the know and was given the following breakdown of our deprecation strategy.
The first point above is also supported by the Coding Guidelines So for this PR, we can delete this without any deprecation steps. I've updated the PR description to remove that question. Are you happy to approve this PR on that advice or shall we wait on a separate approval? cc/ @noisysocks |
aaronrobertshaw
deleted the
remove/unused-border-style-control-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
BorderStyleControlcomponent from the block editor.Why?
The
BorderStyleControlcomponent is no longer in use and has been superceded by the newBorderControlandBorderBoxControlcomponents which include a border style picker.How?
Given the component was experimental, it has simply been removed.
Testing Instructions