Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "How To Get Your Pull Request Reviewed?" to developer handbook #40589

Merged
merged 16 commits into from
May 5, 2022
Merged

Add "How To Get Your Pull Request Reviewed?" to developer handbook #40589

merged 16 commits into from
May 5, 2022

Commits on Apr 25, 2022

  1. Add a new Handbook page: "How To Get Your Pull Request Reviewed?" 

    I published a [Twitter thread](https://twitter.com/adamzielin/status/1515025299133583360) on this exact topic
and it received great feedback. @poena on .org slack suggested it might
be a useful addition to the developer's handbook, and so this PR
adds a new page explaining how to create effective PRs.
    @adamziel
    adamziel committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    0baab25 View commit details
    Browse the repository at this point in the history

  2. Update toc.json

    @adamziel
    adamziel committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    5ef05d6 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Héctor <[email protected]>
    @adamziel @priethor
    adamziel and priethor authored May 4, 2022
    Configuration menu
    Copy the full SHA
    cc107ba View commit details
    Browse the repository at this point in the history

  2. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Héctor <[email protected]>
    @adamziel @priethor
    adamziel and priethor authored May 4, 2022
    Configuration menu
    Copy the full SHA
    bccdca2 View commit details
    Browse the repository at this point in the history

  3. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Héctor <[email protected]>
    @adamziel @priethor
    adamziel and priethor authored May 4, 2022
    Configuration menu
    Copy the full SHA
    e4e13d6 View commit details
    Browse the repository at this point in the history

  4. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Dave Smith <[email protected]>
    @adamziel @getdave
    adamziel and getdave authored May 4, 2022
    Configuration menu
    Copy the full SHA
    1797e81 View commit details
    Browse the repository at this point in the history

  5. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Dave Smith <[email protected]>
    @adamziel @getdave
    adamziel and getdave authored May 4, 2022
    Configuration menu
    Copy the full SHA
    a13db47 View commit details
    Browse the repository at this point in the history

  6. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Dave Smith <[email protected]>
    @adamziel @getdave
    adamziel and getdave authored May 4, 2022
    Configuration menu
    Copy the full SHA
    7f1676c View commit details
    Browse the repository at this point in the history

  7. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Dave Smith <[email protected]>
    @adamziel @getdave
    adamziel and getdave authored May 4, 2022
    Configuration menu
    Copy the full SHA
    ab510bc View commit details
    Browse the repository at this point in the history

  8. Update docs/contributors/how-to-get-your-pull-request-reviewed.md 

    Co-authored-by: Dave Smith <[email protected]>
    @adamziel @getdave
    adamziel and getdave authored May 4, 2022
    Configuration menu
    Copy the full SHA
    24fbabc View commit details
    Browse the repository at this point in the history

  9. Remove the tweet reference

    @adamziel
    adamziel committed May 4, 2022
    Configuration menu
    Copy the full SHA
    8c10842 View commit details
    Browse the repository at this point in the history

  10. Move how-to-get-your-pull-request-reviewed to docs/contributors

    @adamziel
    adamziel committed May 4, 2022
    Configuration menu
    Copy the full SHA
    a873197 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'docs/how-to-get-your-pull-request-reviewed' of github.c… 

    …om:WordPress/gutenberg into docs/how-to-get-your-pull-request-reviewed
    @adamziel
    adamziel committed May 4, 2022
    Configuration menu
    Copy the full SHA
    15dfda4 View commit details
    Browse the repository at this point in the history

  12. Link the new tutorial back to the code review section

    @adamziel
    adamziel committed May 4, 2022
    Configuration menu
    Copy the full SHA
    2c01420 View commit details
    Browse the repository at this point in the history

  13. Regenerate manifest.json

    @adamziel
    adamziel committed May 4, 2022
    Configuration menu
    Copy the full SHA
    085a916 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Clarify to bring up the discussion topics

    @adamziel
    adamziel committed May 5, 2022
    Configuration menu
    Copy the full SHA
    5d258da View commit details
    Browse the repository at this point in the history