Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Block: Add window to the optional chaining #40394

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Image Block: Add window to the optional chaining #40394

merged 2 commits into from
Apr 19, 2022

Conversation

EliezerSPP
Copy link
Contributor

What?

Add window to the optional chaining to avoid the error "wp is not defined" when its working outside a WordPress enviroment

@talldan talldan added [Type] Bug An existing feature does not function as intended [Package] Block library /packages/block-library [Block] Image Affects the Image Block labels Apr 19, 2022
talldan
talldan approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@talldan talldan merged commit fe054f7 into WordPress:trunk Apr 19, 2022
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@EliezerSPP @talldan