Quote v2: add transforms #39718
Merged
Quote v2: add transforms #39718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +442 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
bb4a8f1
to
c4af3aa
Compare
|
@mtias What should happen to the pull quote block? Should that we a style variation of the quote block? Or why is that block still around? |
|
@oandregal Are e2e tests ran with the new quote block or when do we make that switch? It would be good to know what tests are passing and failing |
|
Two issues I'm seeing: When I create a quote with The styling of the quote looks weird. There's two lines. And when the quote is no longer selected, the lines disappear. |
|
Another issue: why is there an "add attribution" below the quote and above the quote? We should pick one. When I click on the toolbar button, I can no longer select the block wrapper for some reason... |
|
Hm, the raw transform is also not working for me 🤔 |
ellatrix
reviewed
Mar 25, 2022
c4af3aa
to
ca50ee5
Compare
|
@ellatrix I'd like to keep this PR focused on the transforms so PR's size & concern is manageable :) The things I've seen that we need to do outside the transforms are listed here at the moment: interaction of the attribution button, deprecations, etc.
The tests would be enabled when #25892 is updated to make v2 the default. I can do that after this lands. |
|
I've just rebased to get #39729 in which fixes issues with filling the |
@ellatrix What html input are you using? |
|
ok, the only issue I see now is the focus on the |
|
Thoughts for the prefix transform
Given all this, I'd suggest we investigate this issue separately and do not block this PR by this issue. @ellatrix thoughts? |
|
The <figure>
<blockquote>
<p>Paragraph.</p>
<ul>
<li>list</li>
</ul>
<code>rm -rf</code>
</blockquote>
<figcaption>Author</figcaption>
</figure>It doesn't with the same code but without the |
|
I'm still seeing the paste issue when copying the content here: https://codepen.io/iseulde/pen/eYyvJbd There's no quote and the two paragraphs in the quote disappear. When I remove the image, it works as expected indeed. Let's try to figure this out separately then. |
This reverts commit 9c2650a.
9756835
to
f101a6c
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15486
Related #25892
What?
This PR adds transforms to the Quote v2.
How?
*transform.*transform.>prefix<blockquote><p /><cite /></blockquote><figure><blockquote/><figcaption /></figure>. It ignores the cite from the old markup.*)*transform.*transform.*)Testing Instructions
Content for testing the `raw` transform
TODO
Merge Quote v2: update how attributes are registered #39729 (it updates how the block is registered and fixes the issues withattribution).Update transforms to consider other attributes (anchor, align, etc). Specially when coming from pullquote.>prefix transformation, investigate if we can make the focus to start in the inner content instead of in the wrapper. Before, the paragraph was focused and users could start typing. To be addressed in a follow-up.rawtransform:attributionfromfigcaptionnot working.<img src=""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/>element, it doesn't transfom it to a quote