Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Global Styles code to continue adding settings & styles #38883

Merged
merged 7 commits into from
Feb 21, 2022
Merged

Update Global Styles code to continue adding settings & styles #38883

merged 7 commits into from
Feb 21, 2022

Commits on Feb 18, 2022

  1. New settings (works in WordPress 5.9) 

    Rename wp_get_global_settings to gutenberg_get_global_settings.

In WordPress 5.9 the wp_* function is already defined,
so we can't override them. It's calling the existing
WP_Theme_JSON classes in WordPress core so it won't pick up
the plugin modification.

In the plugin, to make sure these changes work fine in 5.9
as well, we need to use the gutenberg_* function instead.
    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    d4731b1 View commit details
    Browse the repository at this point in the history

  2. New styles (works in WordPress 5.9)

    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    5c962cf View commit details
    Browse the repository at this point in the history

  3. Fix for WordPress 5.9: gutenberg_get_global_stylesheet should call th… 

    …e Gutenberg classes
    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    10662a1 View commit details
    Browse the repository at this point in the history

  4. Fix lint issues

    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    c55e03a View commit details
    Browse the repository at this point in the history

  5. Move functions to the compat/6.0 folder 

    While this PR does not do any behavioral change,
we still need to call the plugin clasess when the
minimum plugin version is 5.9 (at which point,
the compat/5.9 is removed).
    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    3d5b881 View commit details
    Browse the repository at this point in the history

  6. Use the plugin classes in the REST endpoint 

    The endpoint landed in WordPress 5.9, so we need to make sure even
in this environment the plugin will call the WP_Theme_JSON_* classes.
    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    9968127 View commit details
    Browse the repository at this point in the history

  7. Fix lint issues

    @oandregal
    oandregal committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b4eec10 View commit details
    Browse the repository at this point in the history