Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: update color-picker documentation #38010

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

amustaque97
Copy link
Member

Fixes #38001

Description

After looking into the code and directory structure. Indeed color-picker
README.md file was explaining wrong import. As part of this commit
issue has been addressed.

How has this been tested?

Not sure if documentation change requires any kind of testing. Though I ran once Markdown preview to make sure I didn't break anything else.

Screenshots

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

After looking into the code and directory structure. Indeed color-picker
README.md file was explaining wrong import. As part of this commit
issue has been addressed.
@amustaque97 amustaque97 added [Package] Components /packages/components [Type] Developer Documentation Documentation for developers labels Jan 16, 2022
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I checked the index.js file of the components and the ColorPicker is exported directly

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. That component looks terrifying though. Looks like some type of migration from JS to TS not quite complete...

@Soean Soean merged commit adb5e50 into WordPress:trunk Jan 17, 2022
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 17, 2022
@amustaque97 amustaque97 deleted the fix/38001-fix-color-picker-doc branch January 21, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in colorpicker component docs
4 participants