Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP59: Contextualize "Export" string to differentiate it from other occurrences in WP Core #37660

Merged
merged 1 commit into from
Dec 30, 2021
Merged

WP59: Contextualize "Export" string to differentiate it from other occurrences in WP Core #37660

merged 1 commit into from
Dec 30, 2021

Conversation

audrasjb
Copy link
Contributor

Description

This change aims to differentiate the Site export menuitem from other occurrences of the string in WP Core, because in Core it's not used in the same context. So it several languages, having the same string for both occurrences may lead to inappropriate translations.

See this report from zh_TW locale: https://wordpress.org/support/topic/wordpress-5-9-beta-4-i18n-issue-string-export/
The same goes at least for fr_FR.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Mamaduka
Mamaduka approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @audrasjb.

This change should be backported into 5.9, correct?

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Dec 30, 2021
@Mamaduka Mamaduka merged commit a90a964 into WordPress:trunk Dec 30, 2021
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Dec 30, 2021
@audrasjb
Copy link
Contributor Author

@Mamaduka yes, please 👍

@Mamaduka Mamaduka added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 31, 2021
@Mamaduka Mamaduka added this to 👀 Needs review in WordPress 5.9 Must-Haves via automation Dec 31, 2021
@noisysocks noisysocks removed the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 4, 2022
noisysocks pushed a commit that referenced this pull request Jan 4, 2022
@audrasjb @noisysocks
WP59: Differenciate Export string from other occurrences in WP Core (#…
e8a7a67 
…37660)
@noisysocks noisysocks mentioned this pull request Jan 4, 2022
Closed
@aaronrobertshaw aaronrobertshaw moved this from 👀 Needs review to ✅ Done in WordPress 5.9 Must-Haves Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 5.9 Must-Haves
✅ Done
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@audrasjb @Mamaduka @noisysocks