Fix: Coloring panel is unusable in RTL #37644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra and
ellatrix
as code owners
|
Size Change: -20 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Works as expected in my tests 👍
P.S. I tried to use the RTL Tester plugin for initial tests, but the results were a little off. Then I just switched to RTL language, and it worked as expected.
youknowriad
approved these changes
Dec 29, 2021
|
Cherry-picked for the minor. |
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
added a commit
that referenced
this pull request
Feb 16, 2022
Co-authored-by: George Mamadashvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37605
We were positioning the popover dynamically using isRTL but we should not do that because our CSS to RTL transformer already handles that.
How has this been tested?
I verified in a RTL language that the colors work as the screenshot bellow.
Screenshots