Packages: Fix missing peer dependencies where React used indirectly #37578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
commented
Dec 22, 2021
Comment on lines
+43
to
+44
| "react": "^17.0.0", | ||
| "react-dom": "^17.0.0" |
There was a problem hiding this comment.
That was quite a surprise, but it is inherited from the Enzyme adapter.
gziolo
force-pushed
the
fix/peer-dependencies-react
branch
from
e5b49b6
to
ddcf11b
Compare
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #37264.
The gist of it can be summarized with the #37264 (comment) from @ZebulanStanphill:
A more detailed explanation from @jsnajdr is available in #37264 (comment).
This PR adds
reactandreact-domin all the places shown in the report included by @jonshipman in #37264.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist:
*.native.jsfiles for terms that need renaming or removal).