Add npm-run-all package to simplify running scripts #37558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The npm-run-all package allows for an easier way to run multiple scripts from the package.json file. We are going to run a few scripts to generate api docs, so instead of joining multiple commands using && it can be simplified to creating a command for each and then running: `npm-run-all api-docs:*` Package docs: https://www.npmjs.com/package/npm-run-all
mkaz
added
the
[Type] Project Management
|
Size Change: +25 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
We can also update this line with the newly added command: Line 309 in 8f90816 Now that we generate the docs for blocks based on Line 290 in 8f90816 |
Use the npm-run-all in the lint-staged command that gets run by husky on pre-commit hooks. This allows for checking if any block.json and core blocks are modified that triggers an update to the reference doc.
|
Good catch, the npm-run-all works there also, so just added the |
gziolo
reviewed
Dec 22, 2021
gziolo
added
the
Developer Experience
Co-authored-by: Greg Ziółkowski <[email protected]>
cbravobernal
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The npm-run-all package allows for an easier way to run multiple scripts
from the package.json file. We are going to run a few scripts to
generate api docs, so instead of joining multiple commands using && it
can be simplified to creating a command for each and then running:
npm-run-all api-docs:*Package docs:
https://www.npmjs.com/package/npm-run-all
How has this been tested?
Run:
npm run docs:buildand confirm it runs the set of scripts specified.Types of changes