Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the semicolons from the JSON examples #37129

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

BronsonQuick
Copy link
Contributor

Description

I was working through the "Supports" documentation and realised there are some semicolons in the JSON examples. It's best if we remove these so if people are copy and pasting anything into their JSON files it'll work as expected and they don't need to remove the semicolons manually to get webpack to build assets successfully.

How has this been tested?

I've copied and pasted these into my block.json file and webpack has compiled them successfully.

I was running Chassis locally with npm run start so that webpack would build my assets.

Screenshots

Types of changes

This simply updates the documentation in the Developer Handbook for the "Supports" section in the Block API Reference section.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [] My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

I was working through the "Supports" documentation and realised there are some semicolons in the JSON examples. It's best if we remove these so if people are copy and pasting anything into their JSON files it'll work as expected and they don't need to remove the semicolons manually to get webpack to build assets successfully.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 5, 2021
@github-actions
Copy link

github-actions bot commented Dec 5, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @BronsonQuick! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@aristath
Copy link
Member

aristath commented Dec 6, 2021

Thank you for the fix @BronsonQuick!

The failing tests are not related to this PR so I'll go ahead and merge it since it's a simple docs change 👍

@aristath aristath merged commit 93393d0 into WordPress:trunk Dec 6, 2021
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 6, 2021
@BronsonQuick BronsonQuick deleted the patch-1 branch December 7, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants