Block Library: Add Comments Pagination Numbers block #36890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +663 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Nov 29, 2021
packages/block-library/src/comments-pagination-numbers/block.json
Outdated
Show resolved
Hide resolved
2bd8c6f
to
497e260
Compare
Copy/paste the Query Pagination Numbers block and add a few changes, like the block name.
Co-authored-by: Greg Ziółkowski <[email protected]>
d5b672a
to
bea7423
Compare
|
@DAreRodz, is there anything left in this PR? It's still in a draft mode. |
@gziolo yes, it is. I want to at least support links with a permalink structure other than plain (example.blog/?p=1&cpage=1), which is the only one that is working right now. The paginate_comments_link function that renders the links changes its output according to what it is specified in the permalink settings. So, we would have to either change the Once I end with that, this PR would be ready to review. 🙂 |
|
OK, I've found the problem. It was that I was using Just testing everything before updating this PR's status. 🧑💻 |
cbravobernal
requested changes
Dec 2, 2021
packages/block-library/src/comments-pagination-numbers/block.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Bravo <[email protected]>
cbravobernal
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Looks good to me. But as @gziolo said, I think this pagination numbers block may not work as expected if we load a Latest Comments Block.
Maybe we could work on the pagination links to behave the same as this block, and then create a follow-up issue to handle general comments.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a block that renders links for different page numbers inside the Comments Pagination block. It works similar to the Query Pagination Numbers block.
Will close #35010
How has this been tested?
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).