Update theme.json schema to refer to wp.org URL #36332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
approved these changes
Nov 9, 2021
mkaz
force-pushed
the
update/docs-theme-schema
branch
from
724b6a9
to
8deb2c5
Compare
gziolo
approved these changes
Nov 9, 2021
mkaz
force-pushed
the
update/docs-theme-schema
branch
from
8deb2c5
to
8e69b4f
Compare
grappler
reviewed
Dec 1, 2021
|
|
||
| Editors can pick up the schema and can provide help like tooltips, autocomplete, or schema validation in the editor. To use the schema in Visual Studio Code, add `"$schema": "https://json.schemastore.org/theme-v1.json"` to the beginning of your theme.json file. |
There was a problem hiding this comment.
Is there a plan to create a theme-v1.json version too?
There was a problem hiding this comment.
No. Versioning can be achieved using branch names, for example: https://schemas.wp.org/wp/5.9/theme.json will refer to the schema available in WP 5.9
There was a problem hiding this comment.
Thank you @mkaz, that would be great but that with that URL I am getting a 404. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the URL for theme.json schema to refer to https://schemas.wp.org/trunk/theme.json
A redirect is in place for the wp.org domain that redirects to the schemas in GitHub.
This updates the docs and create-block script to use the wp.org domain.
How has this been tested?
Confirm URL updates are correct.
Types of changes
Switch URLs from SchemaStore to wp.org domain.