Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix parameter type in render function of file block #36262

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Docs: Fix parameter type in render function of file block #36262

merged 2 commits into from
Dec 20, 2021

Conversation

Soean
Copy link
Member

@Soean Soean commented Nov 5, 2021

Description

The second parameter in the render function $content has the type string, not array.

@Soean Soean added [Type] Developer Documentation Documentation for developers [Block] File Affects the File Block labels Nov 5, 2021
@Soean Soean requested a review from ajitbohra as a code owner November 5, 2021 15:10
youknowriad
youknowriad approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks

@Soean Soean merged commit 11fae15 into trunk Dec 20, 2021
@Soean Soean deleted the fix-render_block_core_file-parameter branch December 20, 2021 12:58
@github-actions github-actions bot added this to the Gutenberg 12.3 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] File Affects the File Block [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Soean @youknowriad