Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing controls to Post Excerpt #35959

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add spacing controls to Post Excerpt #35959

merged 1 commit into from
Oct 26, 2021

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Oct 26, 2021

Description

Add spacing controls to Post Excerpt block.

Fixes #35700

How has this been tested?

With a theme that supports spacing,

  1. Add a post excerpt block.
  2. Confirm it does not show margin/padding controls in Inspector.
  3. Apply patch and rebuild
  4. Confirm margin/padding controls show in Inspector
  5. Confir margin/padding show in editor and published view

Types of changes

  • Add supports definition to Post Excerpt block.json

@mkaz mkaz requested a review from ajitbohra as a code owner October 26, 2021 13:14
@mkaz mkaz added [Block] Latest Posts Affects the Latest Posts Block [Block] Post Excerpt Affects the Post Excerpt Block labels Oct 26, 2021
vcanales
vcanales approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkaz mkaz removed the [Block] Latest Posts Affects the Latest Posts Block label Oct 26, 2021
@mkaz mkaz merged commit 59a9764 into trunk Oct 26, 2021
@mkaz mkaz deleted the add/excerpt-controls branch October 26, 2021 15:27
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 26, 2021
@andrewserong andrewserong added the [Type] Enhancement A suggestion for improvement. label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcanales vcanales vcanales approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.

Post excerpt: consider adding spacing controls
3 participants
@mkaz @vcanales @andrewserong