Input Control: Set a color #35481
Closed
Input Control: Set a color #35481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +96 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
I'm afraid I agree, this would be a breaking change on a rather widely-used mixin. I don't know what the "videomaker theme" is so I can't talk about it specifically, but would it be unreasonable to expect theme authors to not add such broad rules (e.g. I kind of think the responsibility/flexibility is in the hands of the theme author. They can scope the |
|
What scope should theme authors to target |
Until there is a clear contract between block authors and theme authors, I don't think there's a foolproof way that will work as expected for every block. Especially when third-party blocks are involved, there's no way to tell programmatically whether a given Under the current circumstances, I would scope it under specific In your input color case specifically, another option might be for the theme to set |
|
Closing in favour of #33494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a theme sets a color for form elements, this gets inherited by text control. If the theme uses a dark background and white text for form elements, then it becomes unreadable:
This PR sets a dark color for text inside input controls, so it looks like this:
I have used
!importantto make sure that the theme styles do get overridden. I'm not super keen on this solution as it feels very heavy handed. My preference would be this fix, but maybe a quick fix is worth it?How has this been tested?
Checkout the videomaker theme and add a table block.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).