Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HelpHub link i18n for page-jumps #35404

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Fix HelpHub link i18n for page-jumps #35404

merged 4 commits into from
Oct 18, 2021

Conversation

audrasjb
Copy link
Contributor

@audrasjb audrasjb commented Oct 6, 2021

We need to make the "page-jumps" HelpHub link translatable.

Fixes #35403

Mamaduka
Mamaduka approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @audrasjb.

@Mamaduka
Copy link
Member

Mamaduka commented Oct 6, 2021

It looks like there's a conflict. We should resolve that before merging.

@audrasjb
Copy link
Contributor Author

audrasjb commented Oct 16, 2021 •
edited
Loading

Thanks for resolving the conflict @Soean 👍

There's a failing test but I'm quite sure it's unrelated.

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 18, 2021
@Soean Soean merged commit 07eb9a1 into WordPress:trunk Oct 18, 2021
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 18, 2021
@Soean Soean added the [Package] Block editor /packages/block-editor label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@Soean Soean Soean approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block editor /packages/block-editor
Projects
None yet
Milestone
Gutenberg 11.8
Development

Successfully merging this pull request may close these issues.

The page-jumps HelpHub link is not translatable
3 participants
@audrasjb @Mamaduka @Soean